• lorty@lemmygrad.ml
    link
    fedilink
    arrow-up
    3
    ·
    4 hours ago

    The team’s position for rejecting this seems reasonable, but then you look at the actual PR and you see that’s one extra line of html on the error pages and I can’t help but feel like it wasn’t a big deal to accept this.

  • Kissaki@programming.dev
    link
    fedilink
    English
    arrow-up
    8
    ·
    edit-2
    6 hours ago

    I can understand the reasoning, but I would have weighed the significant benefit over the little “complexity”/content increase.

    The color inversion is a significant effect. It doesn’t change anything for those that use their own error pages, but significantly improves the situation for people who land on these pages and are bothered by light mode.

    /edit: Their PR close comment was super short (non-telling), but they later commented with some reasonable reasoning that better describes their point of view and considerations.

  • Kissaki@programming.dev
    link
    fedilink
    English
    arrow-up
    4
    ·
    6 hours ago

    Waaaait - I recently implemented a simple dark mode for a simple page and thought color-scheme declares intent/support not influence how it is being rendered. I thought I still had to define dark coloring.

    I just checked and to my surprise the browser indeed serves different default/root coloring when dark color scheme is declared [as well]. :O This means I can simplify my CSS.

    I must have been misled when skimming by “specifies compatibility” and “Component authors must use the prefers-color-scheme media feature to support the color schemes on the rest of the elements.” missing the browser behavior change description.

  • drkt@lemmy.dbzer0.com
    link
    fedilink
    English
    arrow-up
    7
    arrow-down
    4
    ·
    10 hours ago

    I agree with this decision. Don’t make error pages more complicated than they are.

    • dan@upvote.au
      link
      fedilink
      arrow-up
      24
      ·
      edit-2
      10 hours ago

      It’s literally just one line of HTML though:

      <meta name="color-scheme" content="light dark">
      

      Not complicated at all.

      • drkt@lemmy.dbzer0.com
        link
        fedilink
        English
        arrow-up
        2
        arrow-down
        1
        ·
        9 hours ago

        They’re already more complicated than I want them to be so I’m passing on that

      • Boomkop3@reddthat.com
        link
        fedilink
        arrow-up
        1
        arrow-down
        6
        ·
        9 hours ago

        And some css, and accessibility issues. Dark mode isn’t actually great for everyone.

        • dan@upvote.au
          link
          fedilink
          arrow-up
          24
          ·
          edit-2
          9 hours ago

          It doesn’t need any CSS since the Nginx error pages use the browser’s default styling. The meta tag just tells the browser to use its default light or dark mode styling depending on the user’s preference.

          A standard behaviour on all sites that properly implement dark mode is that it adheres to the system-wide dark mode setting by default. If the user doesn’t want dark mode, they’d turn it off system-wide. The site can let the user opt in to dark mode just for that site, but the default is based on the system setting.

        • dan@upvote.au
          link
          fedilink
          arrow-up
          8
          ·
          6 hours ago

          accessibility issues

          Respecting the user’s choice (whether to use dark mode or not) helps accessibility rather than hindering it.

  • notfromhere@lemmy.one
    link
    fedilink
    arrow-up
    7
    arrow-down
    5
    ·
    edit-2
    10 hours ago

    As if I needed another reason to avoid nginx.

    Seems like a very simple, lightweight and elegant solution to keeping the engine up to modern standards. If they were serious about keeping complexity out they wouldn’t have such garbage site configuration.

    • dan@upvote.au
      link
      fedilink
      arrow-up
      7
      ·
      10 hours ago

      Most server admins use custom 404 pages, so the default page isn’t that common in production.