• @seang96A
    link
    English
    659 months ago

    I believe it was a CSV file of every item in all of the shops (comma separated values) and it was being read and stored into memory single threaded so it was maxing out a single core on the CPU.

    • JackbyDev
      link
      fedilink
      English
      639 months ago

      JSON, and it had more to do with how they were checking string lengths. But yeah, the general story is that a random dude fixed massive problems with the text parsing.

      • @seang96A
        link
        English
        339 months ago

        Found an article that details it again since it was a fun read at the time. Looks like it was 10MB json file and the method to read the lines used the expensive length function you mentioned. It also had other simple optimizations too.

        • @ipkpjersi@lemmy.ml
          link
          fedilink
          English
          7
          edit-2
          9 months ago

          Pretty funny that because of all their microtransactions being stored in a JSON file being loaded into memory, that ended up making their game more slow and annoying and frustrating to play.

          I am super curious if the devs knew about this issue but it just wasn’t fixed because it wasn’t given priority by management, or if the devs genuinely had no clue about this?

          The even weirder and funnier thing is I’ve worked with larger JSON files day to day at my job with a much smaller scale than Rockstar/GTA, although I guess it depends on how you work with the files and the fact they were checking string lengths for literally every single piece of data etc.

      • @seang96A
        link
        English
        79 months ago

        Yeah json actually sounds better. Unfortunately it’s still a text file that they were importing the entire thing into memory. Probably worse than CSV since they were probably serializing each item from string into objects. They definitely did it in one of the most laziest ways possible though I bet it worked at the time of development and the vendors probably had very few items.

      • @Appoxo@lemmy.dbzer0.com
        link
        fedilink
        English
        09 months ago

        Not worth to assign a dev to find a bug if the player can just do a toilet break and keeps on generating memes which are free publicity.